Re: DDL in Tran Option - Still a bad idea?

Thank you Rob and Jeff. I have been off for a few days since submitting this and I am just getting back.

I had never used this option before and I have done some tests which actually validated the scope of which ddl in tran works with stored procedures.

So if the tran  is created within the procedure it is allowed as you can see below. However, as you both have indicated, if the transaction is called outside of the procedure this is not allowed and I am afraid this is what the developers are attempting to do. Every procedure that updates data is wrapped in a transaction and this I am afraid is not allowed.

Test 1

=================================

create procedure dbo.usp_test_ddl_in_tran

as

begin

     set nocount on

     begin tran

     create table #temper

     (

       name  varchar(20) not null,

       amount int not null      

     )

     insert into #temper values ('Andy',1)

     insert into #temper values ('Mike',2)

     insert into #temper values ('Molly',3)

     select name, amount from #temper

    commit tran

    -- insert into trantest values (getdate())

end

go

select trancount = @@trancount

go

exec usp_test_ddl_in_tran

go

select trancount = @@trancount

go

Result

trancount

---------

0       

name amount

----- ------

Andy 1   

Mike 2   

Molly 3   

trancount

---------

0

Test 2

===========================

begin tran

-- select trancount = @@trancount

exec usp_test_ddl_in_tran

go

commit tran

go

-- select trancount = @@trancount

-- go

The developers are using the second method for all procedures that update data in the database.

Thanks again